Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README #49

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

oandalib
Copy link
Contributor

Thanks for the great work!

Copy link
Owner

@fractaledmind fractaledmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for these fixes

@@ -256,8 +257,8 @@ Second, you can configure the access credentials via the Rails configuration obj

```ruby
# Set authentication credentials for Litestream
config.litestream.username = Rails.application.credentials.litestream.username
config.litestream.password = Rails.application.credentials.litestream.password
config.litestream.username = Rails.application.credentials.dig(:litestream, :username)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? The dot syntax is supported by Rails for a few point releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using nested credentials for an unrelated purpose in Rails 8, and I ran into issues during Kamal/Docker deployment (assets:precompile). Using dig solved the issue.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

@fractaledmind fractaledmind merged commit 9cf0e5b into fractaledmind:main Oct 24, 2024
10 checks passed
@oandalib oandalib deleted the update-readme branch October 25, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants