Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: salary tracker workshop prototype #727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dario-DC
Copy link
Contributor

Checklist:

Closes #698

self.__name = name
self.__level = level
if level not in Employee.__base_salaries:
raise ValueError(f"Invalid attribute '{level}' for 'level' field.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ValueError(f"Invalid attribute '{level}' for 'level' field.")
raise ValueError(f"Invalid value '{level}' for 'level' field.")

raise ValueError("Cannot give promotion to lower level.")
self.__level = level
salary_difference = new_salary - self.__salary
if salary_difference >= 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if salary_difference >= 0:
if salary_difference > 0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a prototype for Encapsulation Workshop
3 participants