Add new game Zwanzigerrufen #995

tuxor1337 · 2021-10-28T18:14:00Z

This adds an implementation of the eastern Austrian game Zwanzigerrufen which is a simplified version of Königrufen:

The new card pattern is a traditional Tarock pattern used in Austria since the early 19th century, hence it is public domain.

While implementing this game, I fixed #992 and some other card game-related UI stuff.

Checklist

Use a separate branch in your local repo (not master).
I've read and agree with the contribution guidelines.

vdfdev · 2021-10-29T05:07:52Z

Looks great! I had a busy day today so I will get to your PR tomorrow

tuxor1337

I added some comments in the code to clarify what happens in this PR.

tuxor1337 · 2021-10-29T06:18:40Z

web/src/games/frenchTarot/board.tsx

    const highest_bid = Math.max(...G.players.map((P) => P.bid));
-    const all_bids = [0, 1, 2, 3, 4];
+    const all_bids = [Contract.Pass, Contract.Small, Contract.Guard, Contract.GuardWithout, Contract.GuardAgainst];


Part of this PR just replaces plain numbers in frenchTarot by enums.

great, this is much better

tuxor1337 · 2021-10-29T06:21:00Z

web/src/games/zwanzigerrufen/locales/pt.json

+  "description": "Jogo de Cartas da Áustria Oriental",
+  "descriptionTag": "Jogue Zwanzigerrufen online!",
+  "instructions": {
+    "text": "Para uma descrição do jogo, por favor leia a página da Wikipedia: https://en.wikipedia.org/wiki/Zwanzigerrufen\n\nToda a arte usada nessa implementação é do baralho de cartas \"Industrie und Glück\" da primeira metade do século XIX e disponível no domínio público: https://en.wikipedia.org/wiki/Industrie_und_Gl%C3%BCck"


Please check the portuguese translation, I just took some strings from other card games and used a translator for the rest.

pretty good job :)

tuxor1337 · 2021-10-29T06:23:00Z

web/src/gamesShared/components/cards/Card.stories.tsx

+const Template = ({ color, value, pattern, ...rest }) => {
+  return <Card pattern={pattern} type={{ color: color, value: value }} {...rest} />;


The storybook template for the Card component now gives select and range controls to specify the CardColor and value of the card.

tuxor1337 · 2021-10-29T06:24:05Z

web/src/gamesShared/components/cards/Card.tsx

+      [col, row] = cardBlank;
+      text = `CardColor.${CardColor[C.color]} is not available with the ${props.pattern} pattern.`;
+      text += ` Supported colors are: ${colors.map((c) => CardColor[c]).join(', ')}.`;


Unsupported combinations of CardColor and Pattern now cause the Card component to show a blank card with an error message string on it. This should only be relevant for the storybook page. In real games, this should never happen if the game is correctly implemented.

@tuxor1337 is "color" the suit (club, hearts, spades, diamonds)? I noticed the name in my examination and thought it might be. Suggest we refactor that name but I defer to your choice; it might make the reuse better understood if we provide an alias to the common name (in English).

I agree that the terminology is mixed up. Most occurrences of "color" should be "suit". I'm sorry for this confusion which comes from my native language German, where the two words have the same meaning in the context of card games.

However, since this requires major changes to all of my card game implementations, I prepared a separate PR to address the issue for all card games and the shared card components at once. I will open that PR once this PR is merged.

tuxor1337 · 2021-10-29T06:27:55Z

web/src/gamesShared/components/cards/Hand.tsx

+    if (props.pattern == Pattern.Tarock) {
+      width_min = 60;
+      width_max = 90;
+      visible_ratio = 0.6;
+    }


For the card hand that is "fanned out" so that cards overlap, the overlap of the cards does now depend on the specified card pattern. Since the (new) Tarock pattern doesn't have numbers/letters in the four corners, the overlap needs to be smaller so that a larger part of the graphics are visible.

In English (sorry for the ethnocentric reference) the tarot are referred to in their major, and minor, "arcana" don't know if your game is a reference to the traditional "oracle" (fortune teller cards)? The arcana in English translate roughly to Canes, Cups, Coins, Swords the Latin (Fr.?) Clubs, Hearts, Diamonds, Spades see this article maybe alias' would make this clearer.

In a card game context, the French suits Clubs, Hearts, Diamonds, Spades are much more common for card games in the Tarot/Tarock-family, see https://en.wikipedia.org/wiki/Tarot_card_games

In a card game context, the French suits Clubs, Hearts, Diamonds, Spades are much more common for card games in the Tarot/Tarock-family, see https://en.wikipedia.org/wiki/Tarot_card_games

Understood. Does the typing support alias'? Perhaps we could support both. I've never played your game but the ref'd link above speaks to the common names in English, Latin, Fr. arcana (suits).

I don't understand your idea: Which alias would you like to have for which existing type?

tuxor1337 · 2021-10-29T06:29:26Z

web/src/gamesShared/components/cards/PlayerZones.module.css

@@ -4,7 +4,6 @@
  bottom: 0;
  left: 0;
  right: 0;
-  margin: 15px 15px 0;


The arrangement of the player zones on the screen is still (and will definitely remain) subject to improvements from time to time. This is really hard for 4 and 5 player games since the layout should be responsive to support both small and large screens in both landscape and portrait mode.

I have some ideas there... I'll be adding some suggestions if you're willing to consider them. The cardinal directions and the player positions should be relative so If I sit north the clockwise play would be north (self), east, south, west in four player games. I want to work on a table concept that allows the players to choose one of these four seats before entering a game -- this could be reused between ALL games as a way to arrange partnerships play order etc. I think showing the card top 1/3 is usually enough in standard playing cards to establish card identity so you can make a hand that is very compact. in each of the cardinal directions.

In contract bridge @vdfdev the most popular card game globally by far duplicate tournament play is organized in n-s/e-w partnerships. The hands are common to all partners played out in standardized rotations (I don't know these but my parents were life master players in the ACBL) and the round consists of 3 "hands" played out in identical sets of cards for each direction -- all permutations make up the tournament so each pair is awarded a score for each of the hands. This is adds to your LIFE MASTER score which makes you eligible for global rankings. In some countries they broadcast these finals annually to HUGE audiences ... If you want some traffic, I believe a good bridge teach/play/tournament facility will immediately show results. /$0.02

See this article on Duplicate Contract Bridge and variants

Maybe let's discuss this in a different context, e.g. in a GitHub issue or on discord.

Maybe let's discuss this in a different context, e.g. in a GitHub issue or on discord.

added [UI/UX]Tournament Support

Thomas Vogt added 7 commits October 26, 2021 21:58

frenchTarot: use Contract enum

a1d3ca7

Add Pattern.Tarock for card components

7ff00b0

Add game Zwanzigerrufen

b1e1682

Fix ci

dd94840

Storybook: Card component

a368af9

zwanzigerrufen: show each player's announcements separately

946043a

cards: more space for the trick to avoid overlaps

60dcc3b

tuxor1337 mentioned this pull request Oct 28, 2021

Inconsistent card face when toggling between Pattern Types #992

Closed

Fix ci

12e6de8

tuxor1337 force-pushed the add_zwanzigerrufen branch from 2544094 to 12e6de8 Compare October 28, 2021 18:47

tuxor1337 commented Oct 29, 2021

View reviewed changes

vdfdev approved these changes Oct 31, 2021

View reviewed changes

vdfdev merged commit 9abc1e6 into master Oct 31, 2021

vdfdev deleted the add_zwanzigerrufen branch October 31, 2021 00:54

tuxor1337 mentioned this pull request Oct 31, 2021

CardColor -> Suit #997

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new game Zwanzigerrufen #995

Add new game Zwanzigerrufen #995

tuxor1337 commented Oct 28, 2021 •

edited

Loading

vdfdev commented Oct 29, 2021

tuxor1337 left a comment

tuxor1337 Oct 29, 2021

vdfdev Oct 31, 2021

tuxor1337 Oct 29, 2021

vdfdev Oct 31, 2021

tuxor1337 Oct 29, 2021

tuxor1337 Oct 29, 2021

cwatsonc Oct 29, 2021

tuxor1337 Oct 29, 2021

tuxor1337 Oct 29, 2021

cwatsonc Oct 29, 2021 •

edited

Loading

tuxor1337 Oct 29, 2021 •

edited

Loading

cwatsonc Oct 29, 2021

tuxor1337 Oct 30, 2021

tuxor1337 Oct 29, 2021 •

edited

Loading

cwatsonc Oct 29, 2021

cwatsonc Oct 29, 2021 •

edited

Loading

tuxor1337 Oct 29, 2021

cwatsonc Oct 30, 2021

		const Template = ({ color, value, pattern, ...rest }) => {
		return <Card pattern={pattern} type={{ color: color, value: value }} {...rest} />;

Add new game Zwanzigerrufen #995

Add new game Zwanzigerrufen #995

Conversation

tuxor1337 commented Oct 28, 2021 • edited Loading

Checklist

vdfdev commented Oct 29, 2021

tuxor1337 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwatsonc Oct 29, 2021 • edited Loading

Choose a reason for hiding this comment

tuxor1337 Oct 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tuxor1337 Oct 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwatsonc Oct 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tuxor1337 commented Oct 28, 2021 •

edited

Loading

cwatsonc Oct 29, 2021 •

edited

Loading

tuxor1337 Oct 29, 2021 •

edited

Loading

tuxor1337 Oct 29, 2021 •

edited

Loading

cwatsonc Oct 29, 2021 •

edited

Loading