Try to add Xunit.v3

[wallymathieu]

No description provided.

[wallymathieu]

I seem to be getting NuGet/Home#12543

/Users/mathieu/src/fs/FsCheck/src/FsCheck.Xunit/FsCheck.Xunit.fsproj : error NU1009: The packages Microsoft.NETFramework.ReferenceAssemblies are implicitly referenced. You do not typically need to reference them from your project or in your central package versions management file. For more information, see https://aka.ms/sdkimplicitrefs [/Users/mathieu/src/fs/FsCheck/FsCheck.sln]

Though I don't really get how that is.

[arialdomartini]

I am afraid that just targeting the new xunit.v3.extensibility.core package won't be enough: xUnit v3 introduced some breaking changes, which require changes to the code of FsCheck.Xunit.PropertyAttribute.

Notably, the XunitTestCase signature in v3 in not compatible with the one in v2: for example, in v2 the first parameter of XunitTestCase is a messsage sink, while in v3 it is a IXunitTestMethod.

[kurtschelfthout]

Thanks for looking at this.

Note FsCheck doesn't use paket anymore.

For the framework thing, I'd just drop the net462 target for the time being. That was only added to help xunit determine .NET FW tests. But honestly, for FsCheck.Xunit3 I'd be ok targetting some recent version of .NET (8?) and dropping framework support.

[wallymathieu]

Thanks! I'm kind of dry coding since I have trouble getting around NU1009. I'll see if it works better on Windows so that I can see about updating this PR.

[wallymathieu]

I had to comment out

    <PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" />

in order to get it to build