SUPPORT-2078: Update Integrations Components for FusionCharts [Contributor Pull Requests] #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butor Pull Requests] Contributer PR #64 changes, Remove Vue dependency and unused function
vishal-appwrk
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link: https://fusioncharts.jira.com/browse/SUPPORT-2078
Contributer PR #64 changes, Remove Vue dependency and unused function
Changes: It was noticed that the vue-fusioncharts dist files are very huge. It looks like it is including the Vue object unnecessarily. (probably accidental?). This also causing the component to print You are running Vue in development mode every time, even in production environment. Proposing to remove the import and the related unused function.