New tool addition: Mash dist #7177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Jul 29, 2025
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
|
Linter is not running for the new tool since it needs to manually be listed in the shed yaml file. Do you recall why this is not a auto repository? |
I dont know. The last this tool was touched by someone was 5 years ago. |
|
@bernt-matthias is this good to be merged? |
tools/mash/test-data/m64326e_231130_052019.hifi_reads.bc2068--bc2068.msh
Outdated
Show resolved
Hide resolved
|
@bgruening and @bernt-matthias can we merge this? This PR has been lying here since couple of weeks. |
SaimMomin12
commented
Aug 19, 2025
SaimMomin12
force-pushed
the
tools/add_mash_dist
branch
from
806b137 to
0048071
Compare
|
@bernt-matthias can we merge this? |
bgruening
reviewed
Sep 10, 2025
| @@ -26,3 +26,9 @@ repositories: | |||
| - test-data | |||
| - tool_data_table_conf.xml.sample | |||
| - tool-data/mash_sketches.loc.sample | |||
| mash_dist: | |||
| description: "mash dist: Estimate distance between query sequences" | |||
| include: | |||
bgruening
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR:
This PR adds a new tool to the mash suite, required for the VGP
Ping @Delphine-L