CEL expression to invalidate setting/unsetting of immutable fields. #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Added immutability rule for setting/unsetting at the lowest possible scope for the field. 2) Added it tests for the same 3) Added new generated crd yaml.
gardener-robot
added
needs/review
|
@Shreyas-s14 Thank you for your contribution. |
gardener-robot
added
the
size/s
|
Thank you @Shreyas-s14 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
shreyas-s-rao
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
@Shreyas-s14 thanks for the quick fix.
/lgtm
/reviewed ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
needs/ok-to-test
renormalize
requested changes
Apr 7, 2025
renormalize
approved these changes
Apr 7, 2025
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
etcd.Specafter creation. This was overlooked in the previous PR for CEL Validation.Which issue(s) this PR fixes:
Fixes #1048
Special notes for your reviewer:
Release note: