Skip to content

Fix bbox crs for OAMaps #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix bbox crs for OAMaps #1999

wants to merge 4 commits into from

Conversation

C-Loftus
Copy link
Contributor

@C-Loftus C-Loftus commented Apr 22, 2025

Overview

This PR fixes the wms_facade map provider and (OAMaps in general) to project the bbox properly.

  • Previously the bbox was being projected with the crs param and not the bbox-crs param. This PR makes the bbox-crs apply to the bbox.
  • Moved the projection code to use transform_bbox and moved it into the map API code instead of the provider. This is since all map providers presumably should support projecting the bbox arg
  • Added a bbox-crs arg for the wms_facade provider since we have to check if the crs is 4326 when checking whether or not to switch the lat/lon (unusual WMS quirk)
  • Added tests for wms_facade since it previously did not have any

Related Issue / discussion

Fixes #1995

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@C-Loftus C-Loftus changed the title Fix bbox crs for wms_face Fix bbox crs for OAMaps Apr 22, 2025
@webb-ben webb-ben added bug Something isn't working OGC API - Maps OGC API - Maps labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OGC API - Maps OGC API - Maps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bbox-crs parameter mishandled in OAMaps
2 participants