chore: validate node config in middleware #229
Conversation
|
hmm, sorry I wasn't clear on this one:
I meant NIP-47 requests (because all of those will blow up if there is no lnClient) I'm not sure if we need this and it looks hard to maintain since we have to check all config options for every backend type. Could we just improve the frontend redirect works? But some of those checks might be good when initially setting up the node (but for the LND one you only need to specify either the hex or file options) |
| // if user == nil { | ||
| // return c.NoContent(http.StatusUnauthorized) | ||
| // } | ||
| if svc.lnClient == nil { |
There was a problem hiding this comment.
I think this is a good check but doesn't fit the name of the middleware, and is not related to the middleware that this would be for (checking if the user has unlocked NWC / has authed in http mode)
There was a problem hiding this comment.
Changed to ValidateNodeMiddleware
|
I cannot test this and am not sure if this is really needed. The frontend will not allow you to get in this state any more with the improved redirects from the onboarding branch that was merged. @im-adithya what do you think? |
|
Closing for now. If you think we should re-open this please open a new PR at https://github.com/getAlby/nostr-wallet-connect-next |
Helps stop frontend from making requests before the setup process is complete.