Feature: Change ARN's to use correct partition #7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
force-pushed
the
feature/partition-support
branch
from
9bf4a49 to
33715c8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7699 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 1087 1087
Lines 92672 92753 +81
=======================================
+ Hits 87419 87497 +78
- Misses 5253 5256 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This is now part of moto >= 5.0.8.dev10 |
This was referenced May 20, 2024
jfmainville
pushed a commit
to jfmainville/moto
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @dfangl 's excellent work here: https://github.com/localstack/moto/tree/hackathon/partitions
Related:
PR where we allowed URL's with different partitions: #6412
PR where we changed STS ARN's to contain the
aws-cnpartition: #7336Outstanding tasks that will be fixed in subsequent PR's: