Add MOTO_DISABLE_GLOBAL_CORS for disabling wildcard CORS
#8409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
requested changes
Jan 5, 2025
There was a problem hiding this comment.
Hi @kangasta! This makes sense - having a 'strict' mode where CORS is only enabled when configured can be useful, and this looks like the right approach.
Would you mind merging in the latest master? That should hopefully fix the build/linter.
kangasta
force-pushed
the
MOTO_DISABLE_GLOBAL_CORS
branch
from
5110e9f to
8af0936
Compare
|
Thank you for the feedback 👍 I rebased this on top of master and added a testcase for the |
kangasta
force-pushed
the
MOTO_DISABLE_GLOBAL_CORS
branch
from
8af0936 to
6a2d51a
Compare
kangasta
force-pushed
the
MOTO_DISABLE_GLOBAL_CORS
branch
from
6a2d51a to
608d212
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8409 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 1225 1225
Lines 105708 105711 +3
=======================================
+ Hits 97916 97919 +3
Misses 7792 7792
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.