-
-
Notifications
You must be signed in to change notification settings - Fork 455
Add E2E tests for the spring sample #4640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ee747ae | 405.43 ms | 485.70 ms | 80.28 ms |
3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, can we keep JDK 8? I'm worried that we start breaking things for customers who might still be on an old version of JDK.
version = "0.0.1-SNAPSHOT" | ||
|
||
java { | ||
sourceCompatibility = JavaVersion.VERSION_1_8 | ||
targetCompatibility = JavaVersion.VERSION_1_8 | ||
sourceCompatibility = JavaVersion.VERSION_17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we implement the tests and still keep JDK 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. I had to change the Gradle of the system-test-support
package. Is the package only internal?
📜 Description
#skip-changelog
Follow up on #4635, with similar changes as the
spring
sample is analogous to thespring-jakarta
sample.One notable difference is that the Spring Boot 2's BOM pulls in Kotlin and Jackson versions that are incompatible with the ones specified in our version catalogue. I therefore included Kotlin and Jackson BOMs after the Spring Boot one. As a nice side effect
spotlessGradleApply
started working again on the sample.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps