Skip to content

Allow no core when custom backend enabled #7407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sagudev
Copy link
Collaborator

@sagudev sagudev commented Mar 24, 2025

Connections
Fixes #7329

Description
Currently wgpu assumes on native only we always need core, but that's not the case now that we have custom backend. Users of custom backend might not want to bring core into deps tree.

Testing
There is a new test and there are also existing tests.

Squash or Rebase? Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

Sorry, something went wrong.

@sagudev
Copy link
Collaborator Author

sagudev commented Mar 24, 2025

I think we will need some platform-deps like we use in wgpu-core. cc @cwfitzgerald

@sagudev
Copy link
Collaborator Author

sagudev commented Mar 24, 2025

I think we will need some platform-deps like we use in wgpu-core. cc @cwfitzgerald

At least if we want that selecting backends will also select core on native, although we might want to let users specify core feature that actually brings in wgpu-core.

Verified

This commit was signed with the committer’s verified signature.
cwfitzgerald Connor Fitzgerald
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev sagudev mentioned this pull request Mar 25, 2025
6 tasks
@cwfitzgerald
Copy link
Member

cwfitzgerald commented Apr 11, 2025

Yeah this is why I didn't really try to solve it - the conditional dependency made things much more complicated, as you need all features to pass through but only conditionally, it's a real mess.

@sagudev
Copy link
Collaborator Author

sagudev commented Apr 12, 2025

Yeah this is why I didn't really try to solve it - the conditional dependency made things much more complicated, as you need all features to pass through but only conditionally, it's a real mess.

Yeah, I give up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test that custom_backend example does not depend on wgpu-core
2 participants