Fix assorted issues with WebGL #7448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
changed the title
cwfitzgerald
requested review from
Copilot and
a team
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR fixes assorted issues affecting WebGL support in the wasm examples, addressing build command consistency, dependency configuration, and error handling for wasm32 targets.
- Updated cargo build commands in the xtask runner to use package flags instead of binary flags.
- Expanded dependency lists for the "noop" feature and adjusted workspace dependency definitions.
- Modified error handling in wgpu-core for wasm32 to ignore timeouts.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| xtask/src/run_wasm.rs | Changed cargo build commands to use package flag (“-p”) instead of binary (“--bin”). |
| wgpu/Cargo.toml | Added dependencies to "noop" feature for consistency with other backends. |
| wgpu-core/src/device/global.rs | Added a wasm32-specific branch for ignoring WaitIdleError::Timeout. |
| examples/features/Cargo.toml | Adjusted workspace dependencies for wgpu across target configurations. |
| Cargo.toml | Removed the "webgl" feature from the wgpu dependency list. |
Comments suppressed due to low confidence (2)
xtask/src/run_wasm.rs:35
- Using the '-p' flag instead of '--bin' changes which artifact is built; please verify that this aligns with the intended build target and doesn't affect other build scenarios.
cargo build --target wasm32-unknown-unknown -p wgpu-examples --no-default-features --features webgpu {release_flag...}
Cargo.toml:70
- Removal of the 'webgl' feature from the wgpu dependency list should be reviewed carefully to ensure it doesn't break setups that depend on explicit webgl support.
"webgl",
Vecvec
pushed a commit
to Vecvec/wgpu
that referenced
this pull request
Apr 11, 2025
* Fix validation error when configuring the surface on WebGL * Remove unneeded `webgl` feature * Fix compilation of the `noop` backend on `wasm32` * Prevent `webgpu` examples from incorrectly falling back to WebGL * Reduce dependency set when building wasm examples * Fix various warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7363
Description
Fixes various small issues with the wasm examples. Each commit is standalone and self-explainatory
Testing
Manually
Squash or Rebase?
Squash
Checklist
cargo fmt.