Java: Make Virtual Dispatch Global, but keep SSA local. #20357
+41
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alexet
force-pushed
the
alexet/java-global-virtual-dispatch
branch
from
ca97e45 to
802cc77
Compare
alexet
force-pushed
the
alexet/java-global-virtual-dispatch
branch
from
802cc77 to
f754d3a
Compare
There was a problem hiding this comment.
Pull Request Overview
Makes Virtual Dispatch computations global while keeping SSA computations local using the forceLocal mechanism. This change aims to improve performance by allowing Virtual Dispatch predicates to be computed once globally while ensuring SSA predicates remain local to avoid unnecessary recomputation.
- Changes overlay annotations from
[local?]to[global]for Virtual Dispatch modules - Keeps SSA module as
[local?]but usesforceLocalfor specific predicates - Introduces wrapper predicates with
forceLocalto maintain local computation for certain SSA operations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| java/ql/lib/semmle/code/java/dispatch/internal/Unification.qll | Changes overlay from [local?] to [global] for unification computations |
| java/ql/lib/semmle/code/java/dispatch/VirtualDispatch.qll | Changes overlay from [local?] to [global] for virtual dispatch analysis |
| java/ql/lib/semmle/code/java/dispatch/ObjFlow.qll | Changes overlay from [local?] to [global] for object flow dispatch analysis |
| java/ql/lib/semmle/code/java/dispatch/DispatchFlow.qll | Changes overlay from [local?] to [global] for dispatch flow computations |
| java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll | Keeps [local?] but adds [global] overlays for specific predicates and introduces forceLocal wrappers |
| java/ql/lib/semmle/code/java/dataflow/SSA.qll | Keeps [local?] but adds forceLocal wrapper for non-local update detection |
alexet
force-pushed
the
alexet/java-global-virtual-dispatch
branch
from
f754d3a to
1d8c324
Compare
alexet
force-pushed
the
alexet/java-global-virtual-dispatch
branch
2 times, most recently
from
aebe611 to
6aab030
Compare
Use forceLocal to achive this.
This allows us to merge them without redundent annoations for now.
alexet
force-pushed
the
alexet/java-global-virtual-dispatch
branch
from
6aab030 to
0d538ec
Compare
|
I have added a commit that removes the redundant annotations and instead adjusts the annotations script. This should mean that this can be merged without waiting for the next release and we can revert that commit then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use forceLocal to achieve this in SSA.
The
WrappedInvocationpart ofdispatchstays local as it is used from some local modules. I am not sure this is ideal, but it doesn't seem like a source of FPs in practice.I have added explicit
overlay[global]annotations so that the SSA library compiles when madeoverlay[local].This needs a nightly compiler to compile without warnings so it can't be merged until that is released (2.23.1 barring hotfixes)Now compiles with the latest release with a commit to revert once the next release happens.