fix: lint errors globally (#59)

cmd/go-readability/main.go

@@ -74,7 +74,7 @@ func rootCmdHandler(cmd *cobra.Command, args []string) {
 
 		fmt.Println(content)
 	} else {
-		cmd.Help()
+		_ = cmd.Help()
 	}
 }
 
@@ -83,7 +83,11 @@ func httpHandler(w http.ResponseWriter, r *http.Request) {
 	textOnly, _ := strconv.ParseBool(r.URL.Query().Get("text"))
 	url := r.URL.Query().Get("url")
 	if url == "" {
-		w.Write([]byte(index))
+		if _, err := w.Write([]byte(index)); err != nil {
+			log.Println(err)
+			http.Error(w, err.Error(), http.StatusBadRequest)
+			return
+		}
 	} else {
 		log.Println("process URL", url)
 		content, err := getContent(url, metadataOnly, textOnly)
@@ -97,7 +101,11 @@ func httpHandler(w http.ResponseWriter, r *http.Request) {
 		} else if textOnly {
 			w.Header().Set("Content-Type", "text/plain")
 		}
-		w.Write([]byte(content))
+		if _, err := w.Write([]byte(content)); err != nil {
+			log.Println(err)
+			http.Error(w, err.Error(), http.StatusBadRequest)
+			return
+		}
 	}
 }
 

parser.go

@@ -955,7 +955,7 @@ func (ps *Parser) grabArticle() *html.Node {
 				// - parent:             1 (no division)
 				// - grandparent:        2
 				// - great grandparent+: ancestor level * 3
-				scoreDivider := 1
+				var scoreDivider int
 				switch level {
 				case 0:
 					scoreDivider = 1

parser_test.go

@@ -3,7 +3,6 @@ package readability
 import (
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
 	"net/url"
 	"os"
 	fp "path/filepath"
@@ -33,7 +32,7 @@ type ExpectedMetadata struct {
 
 func Test_parser(t *testing.T) {
 	testDir := "test-pages"
-	testItems, err := ioutil.ReadDir(testDir)
+	testItems, err := os.ReadDir(testDir)
 	if err != nil {
 		t.Errorf("\nfailed to read test directory")
 	}

scripts/generate-test.go

@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"log"
 	"net/http"
 	nurl "net/url"
@@ -49,7 +48,7 @@ func main() {
 
 	// If test name is 'all', generate test case for all existing test directory
 	if testName == "all" {
-		dirItems, err := ioutil.ReadDir("test-pages")
+		dirItems, err := os.ReadDir("test-pages")
 		if err != nil {
 			log.Fatalf("failed to read test dir: %v\n", err)
 		}
@@ -149,7 +148,9 @@ func downloadWebPage(srcURL string, dstPath string) error {
 	defer resp.Body.Close()
 
 	// Save to file
-	os.MkdirAll(fp.Dir(dstPath), os.ModePerm)
+	if err := os.MkdirAll(fp.Dir(dstPath), os.ModePerm); err != nil {
+		return fmt.Errorf("failed to create directory: %w", err)
+	}
 	dst, err := os.Create(dstPath)
 	if err != nil {
 		return fmt.Errorf("failed to save file: %v", err)