Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-uniswap): fix uniswap bug #389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

developerfred
Copy link
Contributor

Relates to:

#341

Background

What does this PR do?

  • add token lockup and using uniswap tokenlist
  • get token by address or symbol

Docs

Checklist

  • I have tested this change and added the relevant screenshots to the PR description
  • I updated the README if necessary to include the new plugin, wallet, chain, etc.

add token lockup and using uniswap tokenlist
get token by address or symbol
Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 16c7018

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@developerfred
Copy link
Contributor Author

gm @0xaguspunk, take a look here ❤️

@0xaguspunk
Copy link
Contributor

0xaguspunk commented Mar 7, 2025

gm gm @developerfred ! :)

We are actually aiming to fix this in a slightly different way next week by adding a specific plugin to resolve token information from a token symbol! This should solve this issue not only for uniswap but for any prompt/tool where you use token symbols instead of addresses.

Mind if we wait until that is solved and we re-evaluate? I think it should fix this for you!

Thank you for the proactiveness though!!

@developerfred
Copy link
Contributor Author

developerfred commented Mar 7, 2025

gm gm @developerfred ! :)

We are actually aiming to fix this in a slightly different way next week by adding a specific plugin to resolve token information from a token symbol! This should solve this issue not only for uniswap but for any prompt/tool where you use token symbols instead of addresses.

Mind if we wait until that is solved and we re-evaluate? I think it should fix this for you!

Thank you for the proactiveness though!!

@0xaguspunk

Good, when you open the new plugin, mention me, I would love to see how this construction will be done, hugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants