Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake file #57

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add CMake file #57

wants to merge 5 commits into from

Conversation

enetheru
Copy link

@enetheru enetheru commented Oct 23, 2024

Adding a cmake file to this template brings it inline with the updates to the godot-cpp repository.
This is ongoing work to raise the cmake solution to have feature parity.

This PR is not ready to be merged, I just wanted to get it started.

Related godot-cpp PR's

godotengine/godot-cpp#1595
godotengine/godot-cpp#1598

@enetheru enetheru force-pushed the cmake branch 2 times, most recently from 1b09984 to 80aab92 Compare November 6, 2024 01:13
@enetheru
Copy link
Author

enetheru commented Nov 6, 2024

Since this this cmake solution tracks PR#1598 I have in the godot-cpp repo, until it is merged it requires the godot-cpp module be pointed to the right revision. Locally I've been using this to make that happen:

git submodule set-url -- godot-cpp https://github.com/enetheru/godot-cpp.git
git submodule set-branch -b modernise godot-cpp
git submodule sync
git submodule update --init --recursive --remote

Edit: The above no longer applies, this pr is now synchronised to 4.4

@paddy-exe paddy-exe added the enhancement New feature or request label Mar 4, 2025
@paddy-exe
Copy link
Collaborator

Since this this cmake solution tracks PR#1598 I have in the godot-cpp repo, until it is merged it requires the godot-cpp module be pointed to the right revision. Locally I've been using this to make that happen:

git submodule set-url -- godot-cpp https://github.com/enetheru/godot-cpp.git

git submodule set-branch -b modernise godot-cpp

git submodule sync

git submodule update --init --recursive --remote

I was going to update the template to Godot 4.4 soon anyways since it should be backwards compatible all the way. That would also update Godot-cpp.

@enetheru
Copy link
Author

enetheru commented Mar 4, 2025

I was going to update the template to Godot 4.4 soon anyways since it should be backwards compatible all the way. That would also update Godot-cpp.

I think I updated the submodule to 4.4 in this PR so I could test it.
I'm also working on CI for godot-cpp atm, should be helpful for when the same needs to happen here

@paddy-exe
Copy link
Collaborator

I think I updated the submodule to 4.4 in this PR so I could test it.

I'm also working on CI for godot-cpp atm, should be helpful for when the same needs to happen here

Sounds good as well👍🏻 in that case we can wait until your PR is in a mergeable state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants