Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include env["suffix"] in binary names for macOS and iOS #77

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Include env["suffix"] in binary names for macOS and iOS #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SConstruct
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ filepath = ""

if env["platform"] == "macos" or env["platform"] == "ios":
filepath = "{}.framework/".format(env["platform"])
file = "{}.{}.{}".format(libname, env["platform"], env["target"])
file = "{}{}".format(libname, env["suffix"])

libraryfile = "bin/{}/{}{}".format(env["platform"], filepath, file)
library = env.SharedLibrary(
Expand Down
2 changes: 1 addition & 1 deletion bin/ios/ios.framework/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleExecutable</key>
<string>libEXTENSION-NAME.macos.template_release</string>
<string>libEXTENSION-NAME.ios.template_release.universal</string>
<key>CFBundleName</key>
<string>Godot Template Cpp</string>
<key>CFBundleDisplayName</key>
Expand Down
2 changes: 1 addition & 1 deletion bin/macos/macos.framework/Resources/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleExecutable</key>
<string>libEXTENSION-NAME.macos.template_release</string>
<string>libEXTENSION-NAME.macos.template_release.universal</string>
<key>CFBundleName</key>
<string>Godot Cpp Template</string>
<key>CFBundleDisplayName</key>
Expand Down
8 changes: 4 additions & 4 deletions demo/bin/example.gdextension
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ compatibility_minimum = "4.1"

[libraries]
; Relative paths ensure that our GDExtension can be placed anywhere in the project directory.
macos.debug = "./macos/macos.framework/libEXTENSION-NAME.macos.template_debug"
macos.release = "./macos/macos.framework/libEXTENSION-NAME.macos.template_release"
ios.debug = "./ios/ios.framework/libEXTENSION-NAME.ios.template_debug"
ios.release = "./ios/ios.framework/libEXTENSION-NAME.ios.template_release"
macos.debug = "./macos/macos.framework/libEXTENSION-NAME.macos.template_debug.universal"
macos.release = "./macos/macos.framework/libEXTENSION-NAME.macos.template_release.universal"
ios.debug = "./ios/ios.framework/libEXTENSION-NAME.ios.template_debug.universal"
ios.release = "./ios/ios.framework/libEXTENSION-NAME.ios.template_release.universal"
windows.debug.x86_32 = "./windows/libEXTENSION-NAME.windows.template_debug.x86_32.dll"
windows.release.x86_32 = "./windows/libEXTENSION-NAME.windows.template_release.x86_32.dll"
windows.debug.x86_64 = "./windows/libEXTENSION-NAME.windows.template_debug.x86_64.dll"
Expand Down
Loading