Ditch .framework folders and let the export plugin copy and sign .dylib files

[unvermuthet]

This is a draft PR for removal of .framework folders.

At the last GDExtension meeting we discussed the possibility of ditching the use of framework folders for MacOS and iOS and letting Godot's export plugin handle the code signing. This simplifies the directory structure, the library paths in the .gdextension file and the builds.yml workflow.

MacOS and iOS binaries ...

• are no longer in .framework folders
• no longer get signed by the builds.yml workflow
• include the whole suffix and have the .dylib extension now (supersedes Include env["suffix"] in binary names for macOS and iOS #77)

Before we can consider this it needs to be verified that the export plugin's codesigning of shared objects is functional.

Here are the logs of the export on MacOS:
https://pastebin.com/EB1Pj5B5 (built-in signing)
https://pastebin.com/8qYa1sf4 (xcode signing)

You can see on line 18 that the .dylib file was copied to Contents/Framework/ without a .framework folder. The resulting project is functional so I can confirm that the .framework folder doesn't seem to be required. I can't however speak on the code signing since I don't have an Apple Developer Account.

If you want to reproduce you can export a project on MacOS with this artifact.

[Ivorforce]

You can see on line 18 that the .dylib file was copied to Contents/Framework/ without a .framework folder. The resulting project is functional so I can confirm that the .framework folder doesn't seem to be required.

Unfortunately, .framework is required on iOS because otherwise, you won't be accepted into the app store. Here's an article that goes into this.

I haven't been able to successfully export an iOS project so far, so I can't confirm whether it creates .framework or not. The cpp code certainly seems to think so: https://github.com/godotengine/godot/blob/e567f49cbb292dd6bb628348e67c1f3c2a3a5f99/platform/ios/export/export_plugin.cpp#L1484

[unvermuthet]

In that case we could either upgrade the export plugins to create the folders or keep the .framework folders and just get rid of the signing.

[Ivorforce]

If I'm seeing it correctly, you tested macOS export. I think only the iOS godot exporter upgrades to .framework. So it could still be that it already does it and we don't need to touch it.

[unvermuthet]

I tried my luck at exporting an iOS build but didn't get far. The macOS VM I'm running on my Proxmox server is very laggy. I'm going mental trying to make it work. It would be neat if someone could go metal instead - haha - and try exporting a project with the artifact for iOS and post the --verbose logs here.

[Ivorforce]

I'm on mac and I've been trying, but I'm not sure its possible without a dev account. Certainly complained every time so far.

[unvermuthet]

I tried exporting the project for iOS. It didn't succeed but there are interesting errors before the critical failure. Only happens with the GDExtension installed. Here are the full logs: https://pastebin.com/xBZru8VH. No mention of the extension's dylib.

Exporting additional assets
ERROR: Condition "err != OK" is true. Returning: err
   at: _export_additional_assets (platform/ios/export/export_plugin.cpp:1853)
ERROR: Condition "err" is true. Returning: err
   at: _export_additional_assets (platform/ios/export/export_plugin.cpp:1895)

The dylibs should be processed in _export_additional_assets. The two errors could be traced like this:

export_plugin.cpp:1853
export_plugin.cpp:1895
=> _copy_asset L1759
=> some return in _convert_to_framework

[unvermuthet]

Since bruvzg confirmed on RocketChat that the iOS exporter should convert the raw dylibs to frameworks we should keep pursuing this.

Godot iOS exporter should support any of the options, dynamic Framework, static or dynamic Framework, raw dylibs should also be auto-converted to Frameworks.