Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 4.4 #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update to 4.4 #79

wants to merge 1 commit into from

Conversation

paddy-exe
Copy link
Collaborator

Contains changes to .gitignore file due to the addition of .uid files

Question is if we should add the .uid file?

Contains changes to .gitignore file due to the addition of .uid files
@paddy-exe paddy-exe added the enhancement New feature or request label Mar 4, 2025
@dsnopek
Copy link
Contributor

dsnopek commented Mar 4, 2025

Question is if we should add the .uid file?

Hm. If uid's are supposed to be unique, then I guess we shouldn't add the .uid files? Otherwise everyone who copies the template gets the same uid's, whereas if we leave them out, then Godot generates new unique ones for each project

@Ivorforce
Copy link
Contributor

Ivorforce commented Mar 4, 2025

I think .uid files should be part of godot-cpp repos. It will likely not matter in most cases, but having consistent IDs across installs will make it more transparent what's happening in possible error reports or when an extension is removed and reinstalled.

If uid's are supposed to be unique [...]

I think it's fine as long as they're unique within one project. I don't see a reason to have them be unique outside of it. Though perhaps I'm missing something about their design that would warrant that.

@dsnopek
Copy link
Contributor

dsnopek commented Mar 4, 2025

I think it's fine as long as they're unique within one project. I don't see a reason to have them be unique outside of it. Though perhaps I'm missing something about their design that would warrant that.

Well, if the .gdextension file in the template gets a .gdextension.uid, and multiple people make GDExtensions via the template and distribute them on the asset library, we could end up with multiple GDExtensions on the asset library having the same uid in their .gdextension.uid.

I'm not sure it would even actually cause problems, but I think we'd want to try and discourage something like that from happening.

The test project within godot-cpp itself should have it's .uid files saved in the repo, though. I don't think it does currently.

@unvermuthet
Copy link
Contributor

unvermuthet commented Mar 5, 2025

I think they should be excluded from the template and regenerated. But adding them to the .gitignore seems like a bad idea. They should be committed once regenerated by the user. Is the a way to do this in .gitattributes?

@paddy-exe
Copy link
Collaborator Author

paddy-exe commented Mar 5, 2025

I think they should be excluded from the template and regenerated. But adding them to the .gitignore seems like a bad idea. They should be committed once regenerated by the user. Is the a way to do this in .gitattributes?

I mean we could alternatively just not commit it here. That would make it easier. The downside is that we will have to make sure it won't ever be committed in the future. Not sure how this might be possible via gitattributes though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants