Skip to content

Commit

Permalink
Add visibility to the IR rule.
Browse files Browse the repository at this point in the history
This is accomplished by allowing `visibility` to be picked up by
`kwargs`.
  • Loading branch information
reventlov committed Sep 5, 2024
1 parent aba168d commit 0972886
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions build_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ There is also a convenience macro, `emboss_cc_library()`, which creates an

load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")

def emboss_cc_library(name, srcs, deps = [], visibility = None, import_dirs = [], enable_enum_traits = True, **kwargs):
def emboss_cc_library(name, srcs, deps = [], import_dirs = [], enable_enum_traits = True, **kwargs):
"""Constructs a C++ library from an .emb file."""
if len(srcs) != 1:
fail(
Expand All @@ -45,7 +45,6 @@ def emboss_cc_library(name, srcs, deps = [], visibility = None, import_dirs = []
cc_emboss_library(
name = name,
deps = [":" + name + "_ir"],
visibility = visibility,
enable_enum_traits = enable_enum_traits,
**kwargs
)
Expand Down

0 comments on commit 0972886

Please sign in to comment.