Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh: On Linux force use of latest Clang #8522

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

build.sh: On Linux force use of latest Clang #8522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,17 @@ BUILD_CUSTOM_TARGETS=
UNAME=$(uname)
LC_UNAME=$(echo "${UNAME}" | tr '[:upper:]' '[:lower:]')

if [[ "$LC_UNAME" == "linux" ]]; then
# On Linux both GCC and Clang are commonly available, but CMake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe exiting when clang is not available would be helpful as well. Otherwise, we'd get a cmake error that's less scrutable (?).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, looks like this will break our github workflows since we're not using the latest clang version on system but a fixed one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still struggling to build anyway. E.g. the SDL2 build isn't picking up stdint.h typedefs, and I am not chasing everything down. So this is getting opportunistic for me.

# will default to GCC.
# Force use of Clang, and pick the highest-numbered version.
CLANG_VER=$(ls -1 /usr/include/clang | fgrep -v . | sort -n | tail -1)
export CC=${CC-/usr/bin/clang-$CLANG_VER}
export CXX=${CXX-/usr/bin/clang++-$CLANG_VER}
export CXXFLAGS=${CXXFLAGS--stdlib=libc++}
export COMPILER_OPTION="-DCMAKE_C_COMPILER=$CC -DCMAKE_CXX_COMPILER=$CXX -DCMAKE_CXX_FLAGS=$CXXFLAGS"
fi

# Functions

function build_clean {
Expand Down Expand Up @@ -268,6 +279,7 @@ function build_desktop_target {
-DIMPORT_EXECUTABLES_DIR=out \
-DCMAKE_BUILD_TYPE="$1" \
-DCMAKE_INSTALL_PREFIX="../${lc_target}/filament" \
${COMPILER_OPTION} \
${EGL_ON_LINUX_OPTION} \
${FGVIEWER_OPTION} \
${WEBGPU_OPTION} \
Expand Down
Loading