Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarndings 20: Version 1.001; ttfautohint (v1.8.4.7-5d5b) added #8905

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

emmamarichal
Copy link
Collaborator

Taken from the upstream repo https://github.com/scfried/soft-type-yarndings at commit scfried/soft-type-yarndings@31a5afb.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

Copy link

FontBakery report

fontbakery version: 0.13.0

Check results

[19] Yarndings20-Regular.ttf
🔥 FAIL Checking OS/2 usWinAscent & usWinDescent. family/win_ascent_and_descent
  • 🔥 FAIL

    OS/2.usWinDescent value 200 is too large. It should be less than double the yMin. Current absolute yMin value is 0


    [code: descent]
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Check Google Fonts glyph coverage. googlefonts/glyph_coverage
  • 🔥 FAIL

    Missing required codepoints:

- 0x0024 (DOLLAR SIGN)


- 0x0025 (PERCENT SIGN)


- 0x0026 (AMPERSAND)


- 0x0040 (COMMERCIAL AT)


- 0x005E (CIRCUMFLEX ACCENT)


- 0x0060 (GRAVE ACCENT)


- 0x007C (VERTICAL LINE)


- 0x007E (TILDE)


- 0x00A1 (INVERTED EXCLAMATION MARK)


- 0x00A2 (CENT SIGN)


- 217 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN Checking unitsPerEm value is reasonable. opentype/unitsperem
  • ⚠️ WARN

    In order to optimize performance on some legacy renderers, the value of unitsPerEm at the head table should ideally be a power of 2 between 16 to 16384. And values of 1000 and 2000 are also common and may be just fine as well. But we got 960 instead.


    [code: suboptimal]
⚠️ WARN Check if each glyph has the recommended amount of contours. contour_count
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam	Contours detected: 1	Expected: 2
  • Glyph name: quotedbl Contours detected: 1 Expected: 2

  • Glyph name: numbersign Contours detected: 1 Expected: 2

  • Glyph name: quotesingle Contours detected: 2 Expected: 1

  • Glyph name: parenright Contours detected: 2 Expected: 1

  • Glyph name: plus Contours detected: 5 Expected: 1

  • Glyph name: zero Contours detected: 5 Expected: 2 or 3

  • Glyph name: one Contours detected: 4 Expected: 1

  • Glyph name: three Contours detected: 5 Expected: 1

  • Glyph name: four Contours detected: 4 Expected: 1 or 2

  • 114 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value gpos_kerning_info
  • ⚠️ WARN

    GPOS table lacks kerning information.


    [code: lacks-kern-info]
⚠️ WARN Check math signs have the same width. math_signs_width
  • ⚠️ WARN

    The most common width is 560 among a set of 3 math glyphs.
    The following math glyphs have a different width, though:

Width = 680: greater

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs unreachable_glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- pixel

[code: unreachable-glyphs]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. googlefonts/article/images
  • ⚠️ WARN

    Family metadata at ofl/yarndings20 does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets. googlefonts/metadata/unreachable_subsetting
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+200A HAIR SPACE: try adding symbols2

Or you can add the above codepoints to one of the subsets supported by the font: latin, math, menu, symbols

[code: unreachable-subsetting]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. googlefonts/description/family_update
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. googlefonts/meta/script_lang_tags
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID. googlefonts/vendor_id
  • ⚠️ WARN

    OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths superfamily/list
  • ℹ️ INFO

    ofl/yarndings20


    [code: family-path]
ℹ️ INFO Show hinting filesize impact. hinting_impact
  • ℹ️ INFO

    Hinting filesize impact:

ofl/yarndings20/Yarndings20-Regular.ttf
Dehinted Size 18.7kb
Hinted Size 51.0kb
Increase 32.3kb
Change 173.1 %
[code: size-impact]
ℹ️ INFO Font contains all required tables? required_tables
  • ℹ️ INFO

    This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file googlefonts/description/has_article
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 3 10 63 7 155 0
0% 0% 1% 4% 26% 3% 65% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e merged commit f5ab44a into main Jan 14, 2025
8 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_yarndings20 branch January 14, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Dev / PR Merged
Development

Successfully merging this pull request may close these issues.

2 participants