-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all : Opentelemetry migration away from opencensus #3539
base: master
Are you sure you want to change the base?
Conversation
Thanks for taking this on! This PR is too big for me to be able to usefully review it. Is there any reason we can't do this migration one package at a time? Maybe start with an easy one like |
@vangent other than time constraints, getting the tests to work was fairly non trivial when you maintain a compatibility shim. The same application needs to be monitored by two different services together hence the decision to just make everything switched at once. |
Sorry, I'm not sure I follow your comment.
|
@vangent that is fine
|
We can do this a package at a time. You say that will require starting all over with a compatibility shim -- I'm not suggesting that., just splitting this PR into smaller ones. I am not worried about the intermediate state where some packages are using OpenCensus and others are using OpenTelemetry -- I can hold off on making a release until the transition is complete. Let's start with the |
Pr is an effort to resolve issue #2877 all use of opencensus has been replaced with opentelemetry.