Initial docs for installing on GKE #172
Merged
+495
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hacktobeer @jkppr @tomchop @aarontp -> would you guys mind giving this a try and letting know if this was easy to follow/no failed steps along the way? Should only take ~10-15mins but if it takes longer also would be good to know |
hacktobeer
reviewed
Oct 7, 2024
…ke script, remove .Values.gcp.serviceAccount
Signed-off-by: wajihyassine <wajihyassine@users.noreply.github.com>
jkppr
approved these changes
Oct 28, 2024
|
@wajihyassine I have tested the doc again with your changes and it works for me. @jkppr has some solid comments as well, nothing to add. LGTM. |
hacktobeer
approved these changes
Oct 28, 2024
Co-authored-by: Janosch <99879757+jkppr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates the documentation for deploying OSDFIR Infrastructure on GKE.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.