Enable OSS-Fuzz on Demand via PR Comments. #13120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun trial_build.py libaom hermes zstd --sanitizer coverage --fuzzing-engine libfuzzer |
|
/gcbrun oss_fuzz_on_demand.py libaom hermes zstd --sanitizer coverage --fuzzing-engine libfuzzer |
jonathanmetzman
approved these changes
Mar 20, 2025
| @@ -0,0 +1,33 @@ | |||
| # Copyright 2022 Google LLC | |||
There was a problem hiding this comment.
I think the copyright year is wrong on these.
|
You can merge this now. |
javanlacerda
approved these changes
Apr 1, 2025
infra/build/functions/gcb_test.py
Outdated
| else: | ||
| mock_trial_build_trial_build_main.assert_not_called() | ||
| mock_oss_fuzz_on_demand.assert_called_once_with( | ||
| test_case["expected_command"]) |
There was a problem hiding this comment.
Could you just add this endline here?
| ENTRYPOINT ["python3", "/opt/oss-fuzz/infra/build/functions/gcb.py"] |
|
Approved with nits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for triggering OSS-Fuzz on Demand runs via
/gcbrun oss_fuzz_on_demand.py <projects> --sanitizer <sanitizer> --fuzzing-engine <fuzzing_engine>commands in PR comments.ci_trial_build.pyrenamed togcb.pyto reflect added functionality.Related to b/401215144 .