Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 2 problems in target_experiment.py #13170

Merged
merged 3 commits into from
Mar 29, 2025
Merged

Fixes 2 problems in target_experiment.py #13170

merged 3 commits into from
Mar 29, 2025

Conversation

DonggeLiu
Copy link
Contributor

@DonggeLiu DonggeLiu commented Mar 27, 2025

  1. Insufficient timeout. Cloud Build Timeout = waiting time + execution time. Some executions timed out because they waited for too long. Since Cloud Build does not have an execution-only timeout config, the new 12 hour overall time out should be sufficient.
  2. Cleanup JCC. We have to do this because some projects are not even compatible with the current minimum scaffold. This mostly happens when they identifying which CC is being used, and is likely because of the way they read/expect stdout/stderr from commands.

BTW, we can further simplify this script. E.g., no need to save build log as compilation is done within agents.
But it's not a high priority at this point. We can do it in GSoC.

@DonggeLiu DonggeLiu requested a review from oliverchang March 27, 2025 04:09
@DonggeLiu DonggeLiu merged commit e3ba29c into master Mar 29, 2025
18 of 19 checks passed
@DonggeLiu DonggeLiu deleted the target-exp-fixes branch March 29, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants