New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enhance quote to handle empty args #1113

Merged

antonmedv merged 1 commit into google:main from antongolub:fix-quote-empty

Mar 1, 2025

Collaborator

antongolub commented Mar 1, 2025 •

edited

Loading

closes #999
closes #1112

const _$ = $({ prefix: '', postfix: '' })
const p1 = _$`echo ${['-n', 'foo']}`
assert.equal(p1.cmd, 'echo -n foo')
assert.equal((await p1).toString(), 'foo')

const p2 = _$`echo ${[1, '', '*', '2']}`
assert.equal(p2.cmd, `echo 1 $'' $'*' 2`)
assert.equal((await p2).toString(), `1  * 2\n`)

Tests pass
Appropriate changes to README are included in PR

antongolub requested a review from antonmedv

March 1, 2025 16:42


          fix: enhance quote to handle empty args

1e708c1

closes google#999
closes google#1112

antongolub force-pushed the fix-quote-empty branch from 7d59d96 to 1e708c1 Compare

March 1, 2025 16:43

antonmedv approved these changes

View reviewed changes

antonmedv merged commit eff2d70 into google:main

24 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet