Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pre-commit flow #1118

Merged
merged 11 commits into from
Mar 4, 2025
Merged

Added pre-commit flow #1118

merged 11 commits into from
Mar 4, 2025

Conversation

akp111
Copy link
Contributor

@akp111 akp111 commented Mar 3, 2025

Fixes #<number_goes_here>

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

google-cla bot commented Mar 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@akp111
Copy link
Contributor Author

akp111 commented Mar 3, 2025

I have added a flow such that , it checks if fmt:check throws error then run format or else just log no format issue and commit

Closes: #1115

@akp111
Copy link
Contributor Author

akp111 commented Mar 4, 2025

@antongolub let me know if it's fine

@antongolub
Copy link
Collaborator

antongolub commented Mar 4, 2025

@akp111 ,

  1. CLA
  2. Why were size-limit and pkg-lock changed? Let's keep them as is

@akp111
Copy link
Contributor Author

akp111 commented Mar 4, 2025

  1. CLA, i am getting server side error when i am trying to do it
  2. I was getting size-limit exceeded error when i was trying to push. Let me revert the pkg-lock.json and if the size check fails, i can comment the lefthook for size check and push the code again

@akp111
Copy link
Contributor Author

akp111 commented Mar 4, 2025

CLA is also done

@antongolub antongolub merged commit 3efc9eb into google:main Mar 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants