feat(storage): Soft deleted Bucket Restore #28138
Conversation
| def object_retention_param enable_object_retention | ||
| enable_object_retention ? Google::Apis::StorageV1::Bucket::ObjectRetention.new(mode: "Enabled") : nil | ||
| end | ||
| end |
There was a problem hiding this comment.
You probably want to revert this change back and add the newline character back.
There was a problem hiding this comment.
did not understand your concerns here
shubhangi-google
requested review from
yoshi-approver and
a team
as code owners
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
| @@ -223,6 +232,10 @@ def buckets prefix: nil, token: nil, max: nil, user_project: nil | |||
| # account, transit costs will be billed to the given project. This | |||
| # parameter is required with requester pays-enabled buckets. The | |||
| # default is `nil`. | |||
| # @param [Integer] generation generation no of bucket | |||
There was a problem hiding this comment.
| # @param [Integer] generation generation no of bucket | |
| # @param [Integer] generation Generation of the bucket |
|
Hi @bajajneha27 @JesseLovelace can you please take a look at the sample failure
|
| require "google/cloud/storage" | ||
|
|
||
| storage = Google::Cloud::Storage.new | ||
| bucket_name = bucket_name.gsub(/[^a-zA-Z0-9\- ]/, "") |
There was a problem hiding this comment.
We shouldn't do validation like this in a sample, remove this line
There was a problem hiding this comment.
I think this may have something to do with the PermissionDenied error you're getting, this may be causing you to check two different bucket names
There was a problem hiding this comment.
hi @bajajneha27 @JesseLovelace
I have removed the suspected line of code but still getting same failure
|
@shubhangi-google Does the yard / rubocop ci work in your local? |
| bucket_name = bucket_name.gsub(/[^a-zA-Z0-9\- ]/, "") | ||
|
|
||
| # fetching soft deleted bucket with soft_delete_time and hard_delete_time | ||
| deleted_bucket_fetch = storage.bucket bucket_name, generation: generation, soft_deleted: true |
There was a problem hiding this comment.
Error occurs at this line. This could be because the bucket_name is modified in the previous line and the new bucket doesn't exist.
Like Jesse said, try removing the above line. We shouldn't be modifying the bucket_name passed.
|
Can you please double check that the APIARY i.e. google-apis-storage_v1 has soft delete changes? We might have to bump the storage_v1 version in storage gemspec |
Add support for restoring soft deleted bucket.
Operation Supported: