Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use np.nan for numpy >= 2.0.0 #270

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Apr 12, 2024

Starting with numpy==2.0.0, np.NaN is replaced by np.nan. This is discovered by flakybot and this PR ensures both older and newer versions of numpy are supported.

Fixes #267 🦕

@Linchin Linchin requested a review from chalmerlowe April 12, 2024 20:52
@Linchin Linchin requested review from a team as code owners April 12, 2024 20:52
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Apr 12, 2024
@parthea
Copy link
Contributor

parthea commented Apr 12, 2024

@Linchin Please could you check the coverage gap?

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Apr 12, 2024
@Linchin
Copy link
Contributor Author

Linchin commented Apr 12, 2024

@parthea Thanks, this was caused by prerelease tests not being included in coverage test results. From our discussion offline, I merged the unittest-prerelease.yml workflow into unittest.yml and made it one of coverage test's dependencies. This should close the coverage gap.

Note: As unittest.yml is synced by owlbot, I have to exclude unittest.yml from owlbot updates in the future. We are considering make synthtool updates via owlbot manual in order to reduce number of PRs in our repos. For more info, see internal b/330773846.

@Linchin Linchin requested a review from parthea April 12, 2024 23:41
@parthea parthea changed the title fix: use np.nan for numpy >= 2.0.0 test: use np.nan for numpy >= 2.0.0 Apr 13, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2024
@chalmerlowe chalmerlowe merged commit a718ce4 into googleapis:main Apr 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The build failed
3 participants