Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Compact JSON serialization for the dbjson dtype #299

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: Compact JSON serialization for the dbjson dtype #299

merged 1 commit into from
Nov 8, 2024

Conversation

chelsea-lin
Copy link
Contributor

This change optimizes the dbjson serialization by removing whitespace when calling json.dumps. The compact format ensures compatibility with bpd.read_gbq whose pyarrow string values contains the compact format too.

Fixes internal issue 354782342 🦕

@chelsea-lin chelsea-lin requested a review from tswast November 7, 2024 23:33
@chelsea-lin chelsea-lin requested review from a team as code owners November 7, 2024 23:33
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Nov 7, 2024
@tswast tswast merged commit c5e9a10 into main Nov 8, 2024
27 checks passed
@tswast tswast deleted the main_chelsealin_dbjsondump branch November 8, 2024 13:47
@release-please release-please bot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@leahecole leahecole

Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chelsea-lin @tswast @leahecole