Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer variable default for usXClass when variable #1195

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Jan 8, 2025

#1191 had a bug, add a test to expose and fix.

Makes python resources/scripts/ttx_diff.py 'https://github.com/TypeNetwork/Josefinslab#sources/JosefinSlab.designspace' identical.

JMM if happy.

@rsheeter rsheeter added this to the fontc 1.0 milestone Jan 8, 2025
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫸 🪨 ⛰️

@rsheeter rsheeter added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 736be58 Jan 8, 2025
10 checks passed
@rsheeter rsheeter deleted the favordefault branch January 8, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants