-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spread BE kerning across threads #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the main thing missing from all of this, as best I can tell, is some high-level overview of how it works: basically what are the different stages of the work and how to they fit together, what are the invariants at each stage, etc; I think that would be very useful to have somewhere.
orchestration::WorkId as FeWorkId, | ||
}; | ||
use ordered_float::OrderedFloat; | ||
use log::debug; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a general observation but I prefer not to import these macros by name, and instead just call them as log::debug!("my message")
. The main rationale for this is simply that it makes it easier to grep for all the places where you're logging. A secondary rationale is that there's a (loose) convention in Rust to avoid importing functions directly, and instead import their parent module.. I can't find a great source for this, but it's mentioned here by klabnik. I like this convention but am not zealous about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do this relatively consistently; maybe file an issue and we'll fix it eveyrwhere plus add a presubmit?
Builds on #642.
Numbers bounce around a bit run to run but mean + σ on branch is consistantly better than mean - σ on main.
Linux
$ cargo build --release && rm -rf build/ && target/release/fontc ../googlesans/source/GoogleSans/GoogleSans.designspace --emit-timing
:Observations: