Skip to content

Remove the default Maven phase bound to the metadata-copy Maven goal to simplify the use of integration tests #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

Remove the default Maven phase bound to the metadata-copy Maven goal to simplify the use of integration tests #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...aven-plugin/src/functionalTest/groovy/org/graalvm/buildtools/maven/IntegrationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,18 @@ class IntegrationTest extends AbstractGraalVMMavenFunctionalTest {
[ 0 tests failed ]
""".trim()
}

def "run integration tests with failsafe plugin and agent"() {
withSample("integration-test")

when:
mvn '-Pmetadata-copy', 'verify', 'native:metadata-copy'

then:
buildSucceeded
file("target/failsafe-reports").exists()
file("target/failsafe-reports/org.graalvm.demo.CalculatorTestIT.txt").readLines().any(line -> line.contains("Tests run: 6, Failures: 0, Errors: 0, Skipped: 0"))
outputContains "Copying files from: test"
outputContains "Metadata copy process finished."
}
}
2 changes: 1 addition & 1 deletion native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/MetadataCopyMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
import java.util.Objects;
import java.util.stream.Collectors;

@Mojo(name = "metadata-copy", defaultPhase = LifecyclePhase.PREPARE_PACKAGE)
@Mojo(name = "metadata-copy", defaultPhase = LifecyclePhase.NONE)
public class MetadataCopyMojo extends AbstractMergeAgentFilesMojo {

private static final String DEFAULT_OUTPUT_DIRECTORY = "/META-INF/native-image";
Expand Down
48 changes: 48 additions & 0 deletions samples/integration-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,54 @@
</plugins>
</build>
</profile>
<profile>
<id>metadata-copy</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<version>3.5.3</version>
<executions>
<execution>
<goals>
<goal>integration-test</goal>
<goal>verify</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.graalvm.buildtools</groupId>
<artifactId>native-maven-plugin</artifactId>
<version>${native.maven.plugin.version}</version>
<extensions>true</extensions>
<executions>
<execution>
<id>merge-agent-files-in-integration-test</id>
<goals>
<goal>merge-agent-files</goal>
</goals>
<phase>integration-test</phase>
</execution>
</executions>
<configuration>
<skipNativeTests>true</skipNativeTests>
<agent>
<enabled>true</enabled>
<defaultMode>Standard</defaultMode>
<metadataCopy>
<disabledStages>
<stage>main</stage>
</disabledStages>
<merge>false</merge>
</metadataCopy>
</agent>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>
Loading