[Tempo-distributed] Additional initContainers in microservices #3516
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpalexis
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
|
Signed-off-by: Rulx Philomé Alexis <rulxphilome.alexis@gmail.com>
Signed-off-by: Rulx Philomé Alexis <rulxphilome.alexis@gmail.com>
rpalexis
force-pushed
the
feat/adding-initcontainers
branch
from
ba7b966 to
851c1a6
Compare
|
Thanks for the improvement! CI can be picky in this repo about things like the PR title and such. If you make CI happy we can merge. |
Signed-off-by: Rulx Philomé Alexis <rulxphilome.alexis@gmail.com>
rpalexis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for defining and injecting additional
initContainersin various microservices within thetempo-distributedsetup. While some microservices already supported custominitContainers, others did not, which created inconsistencies and limitations for certain use cases.What I Did
initContainersin microservices that previously lacked it.initContainers.Why This is Needed
In some deployments of
tempo-distributed, specific microservices require custominitContainersto handle pre-startup tasks (e.g., configuration, initialization, secrets management). Without this feature, users had to resort to workarounds or were unable to achieve their desired setup.An issue referencing this problem was also identified:
This PR addresses this gap by standardizing
initContainerssupport across all relevant microservices.