Skip to content

feat: LID for query splitting (backport release-3.4.x) #17378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Apr 22, 2025

Backport 66f0f0b from #16958


What this PR does / why we need it:
This Loki Improvement Document proposes a splitting API for Loki queries that helps Loki clients to split and shard queries without parsing and rewriting the original LogQL query.

I personally intend to use this API for the Trino connector which is JVM based.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Karsten Jeschkies <k@jeschkies.xyz>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
(cherry picked from commit 66f0f0b)
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner April 22, 2025 15:11
@loki-gh-app loki-gh-app bot added backport size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Apr 22, 2025
@loki-gh-app loki-gh-app bot requested a review from jeschkies April 22, 2025 15:11
Copy link
Contributor

@JStickler JStickler merged commit 2cb5ad7 into release-3.4.x May 9, 2025
62 checks passed
@JStickler JStickler deleted the backport-16958-to-release-3.4.x branch May 9, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants