chore(docs): Update cache docs #17420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
|
💻 Deploy preview available: |
poyzannur
changed the title
paul1r
reviewed
Apr 23, 2025
paul1r
reviewed
Apr 23, 2025
paul1r
reviewed
Apr 23, 2025
paul1r
reviewed
Apr 23, 2025
paul1r
reviewed
Apr 23, 2025
paul1r
reviewed
Apr 23, 2025
Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
JStickler
reviewed
Apr 24, 2025
docs/sources/operations/caching.md
Outdated
|
|
||
| ## Before you begin | ||
|
|
||
| - It is recommended to deploy three, or in the case of the Helm chart two, dedicated Memcached clusters. | ||
| - As of 2025-02-06, the `memcached:1.6.35-alpine` version of the library is recommended. | ||
| - It is recommended to deploy separate Memcached clusters for these components. |
There was a problem hiding this comment.
"these components" - We should explicitly list the components.
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com>
JStickler
reviewed
Apr 29, 2025
Minor copyedits Signed-off-by: J Stickler <julie.stickler@grafana.com>
loki-gh-app bot
pushed a commit
that referenced
this pull request
May 2, 2025
Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com> Signed-off-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> (cherry picked from commit 1cb4647)
6 tasks
loki-gh-app bot
pushed a commit
that referenced
this pull request
May 2, 2025
Signed-off-by: Poyzan <31743851+poyzannur@users.noreply.github.com> Signed-off-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> (cherry picked from commit 1cb4647)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a start to improve cache documentation on Loki.
It will follow up with a sizing recommendation on this page: https://grafana.com/docs/loki/latest/setup/size/
And a second follow up on memcached-extstore configuration.
Which issue(s) this PR fixes:
Fixes #6201
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR