fix(distributor): validate string table accesses #3819
Conversation
|
|
||
| if err := validateStringTableAccess(prof); err != nil { | ||
| return err | ||
| } | ||
| for _, valueType := range prof.SampleType { | ||
| stt := prof.StringTable[valueType.Type] |
There was a problem hiding this comment.
I think this is the only access we need to fix. We duplicate checks done later in pprof validation – it's fine if we merge this, but let's try to avoid duplication. I'm wondering if the sample type check (loc and func ID checks as well) should be performed here, and not in the pprof validation (along with many other checks)
There was a problem hiding this comment.
I'd like to remove the dupliacate checks, but I am not sure where they are. If I remove the new validations, all new tests fail. Either return 200 when they should not or panic (sample type / sample label string index oob)
There was a problem hiding this comment.
Let's merge it as is and sort it out later
|
We should also make sure we have this fix in f100, which should be cut today |
korniltsev
force-pushed
the
korniltsev/distributor_string_oob_fix_backport
branch
from
1f67537 to
b386df3
Compare
korniltsev
force-pushed
the
korniltsev/distributor_string_oob_fix_backport
branch
from
b386df3 to
4e6d217
Compare
backport #3818 to f/97