Use a default for Dockerfile base image #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Docker warning appears when building a rollout-operator image:
=> WARN: InvalidDefaultArgInFrom: Default value for ARG ${BASEIMAGE} results in empty or invalid base image name (line 13)When using the Makefile this isn't an issue since the arguments are always supplied, but to make the warning go away I moved the defaults from the Makefile to the Dockerfile. Similarly,
BUILDTARGETdefaults torollout-operatorso it also doesn't need to be specified when building the standard image.Related documentation is here: https://docs.docker.com/reference/build-checks/invalid-default-arg-in-from/