polish: use closure instead of CollectFieldsContext #4361
+214
−265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
|
Note: this would probably be most helpfully reviewed by ignoring whitespace differences and possibly side-by-side comparison. |
yaacovCR
force-pushed
the
use-closure
branch
4 times, most recently
from
3d891ab to
c39f840
Compare
yaacovCR
changed the title
yaacovCR
added
the
PR: polish 💅
|
Also subtracts about 50 lines of code, which is always good. From my machine:
|
Mostly whitespace/formatting though, so your mileage may vary, but it helps make the code more readable for me. |
yaacovCR
force-pushed
the
use-closure
branch
2 times, most recently
from
dce58a4 to
d9e3548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #4360, I felt myself trying to reach for opportunity to remove the CollectFieldsContext type/object that I previously introduced; this is accomplished in this separate PR.
Benchmarking on my machine, this seems essentially no better and no worse in the performance realm. I am evaluating this in terms of readability, both in the local sense and in the overall algorithmic sense of better understanding the method and limit of how we are recursing.
Overall, I think it's a minor improvement.