gw-populate-date.php: Added support for dynamic populated modifier values trigerring Populate Date updates.

[saifsultanc]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2875355741/79394

Summary

Populate Date Snippet doesn't work when modifying the date by field value and the input field is populated.

If the source date is selected, a change in modifier value (via GPPA) does not trigger the target date field update. This PR proposes adding a check for the dynamic content loaded and triggering further updates.

BEFORE:
https://www.loom.com/share/05c946d24eaf4fd4a7132ff98e075ef8

AFTER:
https://www.loom.com/share/4dc0dc1ee8fd4cfb859aa79029a9c81e

[coderabbitai]

Walkthrough

This pull request updates the gravity-forms/gw-populate-date.php file by bumping the version from 2.8 to 2.9. It adds a polyfill within the output_script function to define String.prototype.format if not already available, enabling placeholder-based string formatting. Additionally, the changes include new code that sets up an event listener on a modifier field, which triggers the populateDate function when the field's value changes.

Changes

File	Summary
gravity-forms/gw-populate-date.php	- Updated version number from 2.8 to 2.9 - Added a polyfill for String.prototype.format in output_script - Introduced an event listener for the modifier field that calls populateDate upon changes

Sequence Diagram(s)

sequenceDiagram
    participant Browser as Browser
    participant Modifier as Modifier Field
    participant Listener as Event Listener
    participant DateFunc as populateDate Function

    Modifier->>Listener: User changes field value
    Listener->>DateFunc: Call populateDate()
    DateFunc-->>Browser: Update date field dynamically

Loading

Possibly related PRs

• gw-choice-counter.php: Fixed Choice Counter not triggering quantity updates. #1046: Enhances the output_script function with improved event listener functionality, showing a direct connection in modifications to handle event changes.

Suggested reviewers

• veryspry

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62668ca and 2cd72c4.

📒 Files selected for processing (1)

• gravity-forms/gw-populate-date.php (3 hunks)

🔇 Additional comments (3)

gravity-forms/gw-populate-date.php (3)

7-7: Version number updated correctly.

The version number has been incremented from 2.8 to 2.9, which appropriately reflects the new functionality being added.

---

291-300: Good addition of String.prototype.format polyfill.

This polyfill adds the format method to strings if it doesn't already exist, which allows for placeholder-based string formatting. The implementation checks for existing implementation first, avoiding potential conflicts with other libraries.

---

321-332: Excellent fix for the GPPA modifier field update issue.

This new event listener properly addresses the core issue where changes to the modifier value via GPPA weren't triggering updates to the target date field. The implementation:

1. Checks if a modifier exists and if it's within a GWPopulateDate instance
2. Extracts the modifier field ID
3. Sets up an event listener on the modifier field's parent container that triggers the populateDate function when the field value changes

This will ensure the date gets updated when dynamic content is loaded for modifier fields, which directly solves the PR objective.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 2cd72c4