-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Totals badge #108
Totals badge #108
Conversation
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
scripts/display_results.sh
Outdated
echo "<a href='https://www.electricitymaps.com/methodology#carbon-intensity-and-emission-factors' target=_blank rel=noopener>Carbon Intensity</a> for this location: <b>${ECO_CI_CO2I} gCO₂eq/kWh</b>" | tee -a $output $output_pr | ||
printf "<a href='https://sci-guide.greensoftware.foundation/' target=_blank rel=noopener>SCI</a>: <b>%.6f gCO₂eq / pipeline run</b> emitted\n" ${ECO_CI_CO2EQ} | tee -a $output $output_pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing quotes around ${ECO_CI_CO2EQ} in printf. Could fail if value contains spaces or special characters.
Eco-CI Output:
🌳 CO2 Data: |
Eco-CI Output:
🌳 CO2 Data: |
Eco-CI Output:
🌳 CO2 Data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Greptile Summary
This PR adds totals badge functionality and improves dashboard URL configuration in the Eco-CI Energy Estimation tool.
scripts/display_results.sh
showing aggregate energy and carbon metricsdashboard-url
parameter inaction.yml
defaulting to metrics.green-coding.iolocal_ci.example.sh