-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre calculated Machine energy profiles #76
Conversation
…model if hardware was given
Old Energy EstimationEco-CI Output:
📈 Energy graph:
4.40 ┤ ╭╮
4.14 ┤ ╭╮ ╭╮ ││ ╭──╮
3.87 ┤ │╰───╯╰────────╯╰────────────╯ │
3.61 ┤ │ │
3.35 ┤ │ │
3.08 ┤ │ │
2.82 ┤ │ │
2.56 ┤ │ │
2.29 ┤ │ │
2.03 ┤ │ │
1.77 ┼─╯ ╰──
Watts over time 🌳 CO2 Data: |
* main: Removing old GitHub runners Update README.md Changes the ip resolver from ip-api.com to ipapi.com because of https (#78)
The overhead is now down from 23s to 5s
It is unclear to me why the step for a measurement takes 5s. In local testing the time is less than 200ms Even when I look at the detail logs the time seems to be less than 1s. |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
I found the culprit. Aparently sending a process to the background makes GitHub steps hang for a while of the input and output streams are not handled. This code part fixes it: 4425e1b Brought it now also to this branch |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Eco-CI Output:
🌳 CO2 Data: |
Eco-CI Output:
🌳 CO2 Data: |
Eco-CI Output:
🌳 CO2 Data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the new solution. Makes the code a lot clearer and easier to maintain next to all the other advantages.
An uncertainty is if Hyper-Threading / SMT is turned on or off, but we believe it is reasonable to assume that for Shared runners they will turn it on as it generally increases | ||
throughput and performance in shared environments. | ||
|
||
If you have trouble finding out the splitting factor for your system: Open an issue! We are happy to help!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArneTR "Open an issue" could be a link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add
#!/usr/bin/env bash | ||
set -eu | ||
declare -A cloud_energy_hashmap | ||
cloud_energy_hashmap[0.00]=93.3974838256836 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you choose this format? Wouldn't a format
0.00=93.3974838256836
...
be enough? And then use grep/awk to get the values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is source via bash and then accessible via a hashmap. This is way faster than using awk/grep for every utilization value. See my comment regarding the performance.
# but 100x faster in reading. The net gain is after ~ 5 measurements |
That is why the file has this format.
No description provided.