Dev mode #637
Merged
Dev mode #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old Energy EstimationEco-CI Output:
📈 Energy graph:
7.78 ┤ ╭╮ ╭╮
7.18 ┤ ││ ││
6.58 ┤ │╰╮ ╭╮ ││
5.97 ┤ │ │ ╭╯│ │╰╮╭╮
5.37 ┤ ╭╮ │ │ ╭╯ ╰╮ │ ╰╯│
4.77 ┤ │╰╮ │ │ ╭─╮╭╮ │ ╰╮│ │ ╭╮
4.17 ┤ ╭╯ │ ╭───╮ ╭╮ ╭─╮ ╭╮╭╮ │ ╰──╯ ╰╯╰╮ │ ╰╯ │ ╭╮ ╭╮ ││ ╭╮ ╭─────╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭
3.57 ┤ ╭╮╭──╯ ╰───╯ ╰─╯╰────╮ │ ╰───╯││╰╮ ╭╮ ╭╯ │ ╭╯ │ ╭─╯│╭╯╰─╮││ ╭─╯╰─────────────────────────╮╭───╯ ╰────╮╭╮ ╭──╯╰─────╮╭────────────────────────────────╯╰─────╯╰─╮ ╭─╮ ╭╮ ╭───╮╭╯╰╮╭─╮╭───╮╭───╮ ╭──╮╭────╮╭────╮╭╮╭─╮╭─╮╭───╮╭──────╯╰─╮ ╭─╮ ╭╮ ╭╯
2.97 ┤ │││ │╭╯ ╰╯ │ ││ ╭─╮│ │ │ │ │ ││ │││╭╯ ││ │││ ╭╯ ╰╯ │ │ │╭╮ │╰╮│ ││ ╰╯ ││ ││ │╭╯ ╰╯ ││ ╰╯││ ╰╯ ││ ╰╯ │ │ ╰╮ ││ │
2.37 ┤ ╭╮│││ ╰╯ ╰╮││ │ ╰╯ ╰╮ ╭╯ │ │ ╰╯ ││││ ││ ╰╯│ │ │ │ │││ │ ││ ││ ││ ││ ╰╯ ││ ││ ││ │ ╭╮│ │ ││ │
1.77 ┼────╯╰╯╰╯ ╰╯╰─╯ ╰─╯ ╰───────╯ ╰╯╰╯ ╰╯ ╰───────────────────╯ ╰─────────╯ ╰╯╰───────╯ ╰╯ ╰╯ ╰╯ ╰╯ ╰╯ ╰╯ ╰╯ ╰───────╯╰╯ ╰────────╯╰─╯
Watts over time |
|
Sadly not quite the improvement as seen locally :(. The tests now take 6 minutes instead of 12. But at least 2x :) |
Old Energy EstimationEco-CI Output:
📈 Energy graph:
7.82 ┤ ╭╮
7.21 ┤ ││
6.61 ┤ │╰╮ ╭╮ ╭─╮
6.00 ┤ │ │ ││ │ │╭╮
5.40 ┤ ╭╮ │ │ ╭╯╰╮ │ ╰╯│
4.79 ┤ │╰╮ │ │╭╮╭─╮╭╮ ╭╯ ╰╮│ │ ╭╮
4.19 ┤ ╭─╯ │ ╭───╮ ╭╮ ╭╮ ╭──╮ │ ╰╯╰╯ ╰╯│ │ ╰╯ │ ╭╮ ╭╮ ││╭╮╭╮ ╭────╮ ╭╮ ╭╮ ╭─╮
3.58 ┤ ╭╯ ╰───╯ ╰─╯╰───╯╰───╯ ╰──╮╭─╯ ╰╮ │ │ │╰─╯╰─╯╰╯╰╯╰────────────────────────────╯ ╰─────╮ ╭─────────╮╭───────────────────────────────╯╰────╯╰─╮ ╭─╮╭╮ ╭╮ ╭──────────────────────────────────────────╮╭───╯ ╰─╮ ╭─╮ ╭╮ ╭─
2.98 ┤ ╭╯ ││ │ │ │ │ ╰╮ │ ││ │ │ │││ ││ │ ││ │ │ │ ││ │
2.37 ┤ │ ││ │ │ │ ╭╯ │ ╭╯ ╰╯ │ │ ╰╯│ ││ │ ╰╯ │ │ │╭╮ │╰╮│
1.77 ┼────╯ ╰╯ ╰─╯ ╰───────╯ ╰───────────────────╯ ╰────────╯ ╰────────╯╰─╯ ╰────────╯ ╰╯╰───────╯ ╰╯
Watts over time |
ribalba
approved these changes
Dec 31, 2023
| parser.add_argument('--dry-run', action='store_true', help='Removes all sleeps. Resulting measurement data will be skewed.') | ||
| parser.add_argument('--dev-repeat-run', action='store_true', help='Checks if a docker image is already in the local cache and will then not build it. Also doesn\'t clear the images after a run') | ||
| parser.add_argument('--dev-no-metrics', action='store_true', help='Skips loading the metric providers. Runs will be faster, but you will have no metric') | ||
| parser.add_argument('--dev-no-sleeps', action='store_true', help='Removes all sleeps. Resulting measurement data will be skewed.') |
There was a problem hiding this comment.
Maybe this could also take in a sleep value so you can set it to 1 second and such mitigate some of the errors. It defaults to 0
There was a problem hiding this comment.
Thats a nice idea, but the sleeps quickly balloon up even if you only set a 1 to this.
Having no-sleeps and using the healthcheck is actually a breeze and I am fixing the Nextcloud containers atm and it works very well.
Let's reconsider this once we run into issues with the 0-sleep implementation
* main: Adds skip_checks to providers (#566) Bump pytest from 7.4.3 to 7.4.4 (#639) Disabled second PSU provider for VM tests System check providers running (#619) Stderr is now by default UTF-8 (#624) Refactored kill/killpg mechanism to be unified and actually fail on n… (#625) Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636)
|
Eco-CI Output:
📈 Energy graph:
7.86 ┤ ╭╮
7.25 ┤ ││ ╭╮
6.64 ┤ ││ ││╭╮
6.03 ┤ ││ ╭╮ ╭╯│││
5.42 ┤ ╭╯│ ╭─╯╰╮ │ │││
4.81 ┤ │ ╰╮ ╭─╮╭─╮ │ ╰╮│ ╰╯│ ╭╮
4.21 ┤ ╭─╮ ╭─╮ ╭╮ ╭╮╭╮ ╭╮ ╭╮ ╭╮ │ │╭╯ ╰╯ │ │ ╰╯ │ ╭╮╭╮ ││╭╮╭╮ ╭╮ ╭────╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭─╮ ╭
3.60 ┤ ╭╯ ╰──╯ ╰─╯╰───╯╰╯╰──╯╰───────╯╰─╯╰───╮╭─╯ ╰╯ ╰╮ │ │ ╭╯││╰──╯╰╯╰╯╰─╯╰────────────────────────╮╭───╯ ╰──────╮ ╭──────────╮╭──────────────────╯╰──────────────────╯╰─╮ ╭╮╭╮ ╭╮╭────────────────────────────╯╰─────╯╰───╯╰──────╯ ╰─╮ ╭─╮ ╭╮ ╭╯
2.99 ┤ │ ││ │ │ ╰╮ │ ││ ╰╯ │ │ ╰╯ │ ╭╯│││ ╭╯││ │ │ │ ││ │
2.38 ┤ │ ││ │╭╯ │ │ ╰╯ │ │ │ │ │││ │ ││ │ │ ╰╮ ││ │
1.77 ┼────╯ ╰╯ ╰╯ ╰───────╯ ╰───────────────────╯ ╰────────╯ ╰╯╰───────╯ ╰╯ ╰────────╯ ╰────────╯╰─╯
Watts over time |
ArneTR
added a commit
that referenced
this pull request
Jan 1, 2024
* main: Dev mode (#637) Hotfix: resolutions -> resolution Adds skip_checks to providers (#566) Bump pytest from 7.4.3 to 7.4.4 (#639) Disabled second PSU provider for VM tests System check providers running (#619) Stderr is now by default UTF-8 (#624) Refactored kill/killpg mechanism to be unified and actually fail on n… (#625) Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636)
ArneTR
added a commit
that referenced
this pull request
Jan 2, 2024
* main: Dev mode (#637) Hotfix: resolutions -> resolution Adds skip_checks to providers (#566) Bump pytest from 7.4.3 to 7.4.4 (#639) Disabled second PSU provider for VM tests System check providers running (#619) Stderr is now by default UTF-8 (#624) Refactored kill/killpg mechanism to be unified and actually fail on n… (#625) Command fix. Must be list append Refactorings Moved tinyproxy out of if clause Refactoring for error messages and security fix for path echoing (#636) GMT color via own commit hash (#634) Hotfix for branch not main Non-Blocking starlette body read (#633) Bump fastapi from 0.105.0 to 0.108.0 (#632) Updated XGBoost submodule Bump pydantic from 2.5.2 to 2.5.3 (#628) Added stddev to timeline (#627)
|
@ArneTR is there also a PR to update the documentation? |
This was referenced Jan 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces parts of the dev-mode and the healthcheck as mentioned in PR #556 with @davidkopp
Following new flags have been introduced:
--dev-no-sleeps- Skips all sleeps.--dev-no-build- Skips building of the docker containers. This replaces and extends--dry-run--dev-no-metrics- Does not import and run the metric providersSkipping sleeps can lead to containers not being fully booted. This is why the healthcheck was implemented along with the long syntax of depends_on as discussed in #423
All of the flags have also been employed in the test cases. Expecting a decrease from ~12 minutes to ~3 minutes