Skip to content

Conversation

erenboz
Copy link

@erenboz erenboz commented Aug 21, 2025

Alternative implementation for #8531

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.03%. Comparing base (5ed7cf6) to head (cec1bc6).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8532      +/-   ##
==========================================
+ Coverage   81.99%   82.03%   +0.04%     
==========================================
  Files         412      412              
  Lines       40520    40450      -70     
==========================================
- Hits        33225    33185      -40     
+ Misses       5904     5887      -17     
+ Partials     1391     1378      -13     
Files with missing lines Coverage Δ
...alancer/clusterresolver/configbuilder_childname.go 100.00% <100.00%> (ø)

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@erenboz erenboz force-pushed the priority_namegen_alternative branch from 12b972d to 18fd896 Compare August 22, 2025 10:43
@erenboz erenboz force-pushed the priority_namegen_alternative branch from 18fd896 to 99b529f Compare August 22, 2025 10:45
@erenboz erenboz changed the title xds/clusterresolver: [alternative] Revise configbuilder childname generator to fix reuse issues with merge and split scenarios xds/clusterresolver: [wip:alternative] Revise configbuilder childname generator to fix reuse issues with merge and split scenarios Aug 22, 2025
@erenboz erenboz marked this pull request as draft August 22, 2025 12:20
@erenboz erenboz changed the title xds/clusterresolver: [wip:alternative] Revise configbuilder childname generator to fix reuse issues with merge and split scenarios xds/clusterresolver: [alternative] Revise configbuilder childname generator to fix leakage issues with merge and split scenarios Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant