servlet: simplify synchronization in AsyncServletOutputStreamWriter #12284
+53
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panchenko
changed the title
panchenko
force-pushed
the
use-lock-in-servlet
branch
3 times, most recently
from
7c5e6ab to
3734a01
Compare
panchenko
force-pushed
the
use-lock-in-servlet
branch
from
3734a01 to
a3ba516
Compare
| if (toWrite != null) { | ||
| toWrite.run(); | ||
| if (toWrite == completeAction) { | ||
| return; |
There was a problem hiding this comment.
In the earlier code, while returning from completeAction the unpacking of the locked thread was not done but now we are releasing the lock and always letting the container thread be unlocked and run the code in onWritePossible. Seems ok, just pointing out the difference as you probably know this code better.
kannanjgithub
approved these changes
Aug 22, 2025
|
There are still race conditions in this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently synchronization is too low level, seems like can be simplified by using standard lock implementation.