-
Notifications
You must be signed in to change notification settings - Fork 722
Fixes #4200. ExtendedCharInfo needs be enhanced to properly deal with all codepoints #4202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4200. ExtendedCharInfo needs be enhanced to properly deal with all codepoints #4202
Conversation
This reverts commit ef639c1.
…er-surrogatepair-force16colors-fix
…th shrinking" This reverts commit e5edad7.
I spend much time to deal with resize window issues using VSDebugConsole and WSLg but finally I realized that doesn't worth because seems that them are buggy working as legacy consoles with VTS enabled. From now I'll only rely on cmd.exe and conhost.exe in Windows and gnome-terminal in WSLg, where the existent code |
@BDisp please fix conflicts and tests failures and I'll review |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warnings have gotten out of control again.
For each of the files you touch in this PR, can you please ensure there are no warnings generated on build?
I should have asked @tznind to do the same with his iteration zero PR, but dind't notice until too late.
Thanks.
I think almost the CI build warnings, but not the obsolete ones, were suppressed. |
Fixes
Proposed Changes/Todos
WindowsOutput
andWindowsDriver
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)