Skip to content

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jul 22, 2025

Fixes

Proposed Changes/Todos

  • Add support for surrogate pairs in WindowsOutput and WindowsDriver
  • Also supports 16 Colors with a supported font

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner July 22, 2025 16:55
@BDisp BDisp marked this pull request as draft July 22, 2025 16:55
@BDisp BDisp marked this pull request as ready for review July 31, 2025 00:25
@BDisp BDisp mentioned this pull request Jul 31, 2025
8 tasks
@BDisp
Copy link
Collaborator Author

BDisp commented Aug 4, 2025

I spend much time to deal with resize window issues using VSDebugConsole and WSLg but finally I realized that doesn't worth because seems that them are buggy working as legacy consoles with VTS enabled. From now I'll only rely on cmd.exe and conhost.exe in Windows and gnome-terminal in WSLg, where the existent code NetDriver works as expected.

@tig
Copy link
Collaborator

tig commented Aug 31, 2025

@BDisp please fix conflicts and tests failures and I'll review

@BDisp
Copy link
Collaborator Author

BDisp commented Sep 1, 2025

@BDisp please fix conflicts and tests failures and I'll review

Done.

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings have gotten out of control again.

For each of the files you touch in this PR, can you please ensure there are no warnings generated on build?

I should have asked @tznind to do the same with his iteration zero PR, but dind't notice until too late.

Thanks.

@BDisp
Copy link
Collaborator Author

BDisp commented Sep 10, 2025

I think almost the CI build warnings, but not the obsolete ones, were suppressed.

@BDisp
Copy link
Collaborator Author

BDisp commented Sep 11, 2025

I'm also ignoring the follow Unchanged files with check annotations (Preview) because I don't want to touch more unchanged files.

image

@tig tig merged commit ad8ebc9 into gui-cs:v2_develop Sep 11, 2025
11 checks passed
@BDisp BDisp deleted the v2_4200_wider-surrogatepair-force16colors-fix branch September 11, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy consoles width shrink on restore after maximize ExtendedCharInfo needs be enhanced to properly deal with all codepoints
3 participants