Fix face swapping crash due to None face embeddings

[aaddyy227]

• Add explicit checks for face detection results (source and target faces).
• Handle cases when face embeddings are not available, preventing AttributeError.
• Provide meaningful log messages for easier debugging in future scenarios.

Summary by Sourcery

Prevent crashes when face embeddings are not available by adding explicit checks for face detection results and handling cases where face embeddings are missing. Also, add more logging for easier debugging.

Bug Fixes:

• Fix a crash that occurs when face embeddings are not available.
• Add explicit checks for face detection results (source and target faces).
• Handle cases when face embeddings are not available, preventing AttributeError.
• Provide meaningful log messages for easier debugging in future scenarios.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a crash issue in the face swapping functionality that occurs when face embeddings are not available due to face detection failures. It introduces explicit checks for face detection results (source and target faces) and handles cases where either face is not detected, preventing AttributeError. Additionally, it provides meaningful log messages for easier debugging.

Sequence diagram for face swapping with face detection checks

sequenceDiagram
  participant FrameProcessor
  participant FaceDetector
  participant FaceSwapper

  FrameProcessor->>FaceDetector: Detect source_face and target_face
  alt source_face and target_face are detected
    FrameProcessor->>FaceSwapper: swap_face(source_face, target_face, temp_frame)
    FaceSwapper-->>FrameProcessor: temp_frame (with swapped face)
  else source_face or target_face is not detected
    FrameProcessor->>FrameProcessor: Log error message
  end
  FrameProcessor-->>FrameProcessor: Returns temp_frame

Loading

File-Level Changes

Change	Details	Files
Added checks for face detection results to prevent crashes when face embeddings are unavailable.	Added explicit checks for both source and target faces before attempting the face swap. Included a condition to ensure both source_face and target_face are valid before calling swap_face. Added a log message to indicate when face detection fails for either the target or source face.	modules/processors/frame/face_swapper.py

Possibly linked issues

• multiface #1: The PR directly addresses the issue by adding checks for None face embeddings before swapping, resolving the AttributeError crash.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @aaddyy227 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using a logging framework instead of print statements for better control and organization of log messages.
• It might be helpful to include the reason for face detection failure in the log messages to aid debugging.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}